remove static OTEL collector#2609
Merged
Merged
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the static otel-collector Prometheus scrape job from the observability compose config to eliminate duplicate metrics caused by having two OTEL collectors (the dynamic Docker service discovery already covers it).
Changes:
- Drop the static
otel-collectorjob fromprometheus.yml. - Add a changeset entry for v0.16.2 describing the removal.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| framework/observability/compose/conf/prometheus.yml | Removes the static otel-collector scrape job to avoid duplicate metrics. |
| framework/.changeset/v0.16.2.md | Adds a changelog entry describing the removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
skudasov
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we don't have two collectors:
