-
Notifications
You must be signed in to change notification settings - Fork 4
Add CallProxy_TopUp msg #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 krebernisak, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for a new "TopUp" message type to the CallProxy contract, allowing the contract to receive TON coins for maintenance purposes. It also performs some code cleanup by removing debug console.log statements and consolidating duplicate chainId values in tests.
- Implements CallProxy_TopUp message with opcode and encoding/decoding functionality
- Adds message handling logic in the Tolk contract to accept top-up funds without forwarding
- Refactors test code to use a centralized chainId variable instead of duplicated literals
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| contracts/wrappers/mcms/CallProxy.ts | Adds TopUp message type, opcode definition, and message encoding/decoding builders |
| contracts/contracts/mcms/call_proxy.tolk | Implements TopUp message handling logic that accepts funds without proxying |
| contracts/tests/mcms/CallProxy.spec.ts | New test file for CallProxy contract with basic deployment and opcode verification tests |
| contracts/tests/mcms/Integration.spec.ts | Refactors hardcoded chainId values to use a centralized variable |
| contracts/wrappers/mcms/MCMS.ts | Removes debug console.log statement and simplifies return statement formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
patricios-space
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! CallProxy.spec.ts collides with one of the tests suite files, but I guess we can merge them.
307080c to
15962dc
Compare
9d51047 to
41fdd8d
Compare
No description provided.