[NONEVM-3185] [OnRamp] Replace Withdrawable with WithdrawFeeTokens

[patricios-space]

NONEVM-3185

[Copilot]

Pull request overview

This PR implements a new withdrawFeeTokens function for the OnRamp contract that uses the feeAggregator address to collect fees. The implementation replaces the previous withdrawable pattern with a permissionless function that validates token types and enforces balance reserves.

Key changes:

• Added reserve field to DynamicConfig to specify minimum balance that must remain on contract
• Replaced Withdrawable_Withdraw message with OnRamp_WithdrawFeeTokens message
• Added validation for empty fee tokens list and new error codes UnknownToken and InsufficientValue

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/ccip/bindings/onramp/onramp.go	Updated DynamicConfig struct to include Reserve field and added WithdrawFeeTokens struct with validation
pkg/ccip/bindings/onramp/onramp_test.go	Added Reserve field to test configuration
pkg/ccip/bindings/onramp/exitcode_string.go	Updated exit code mappings for new error types
deployment/ccip/sequence/deploy_ccip.go	Added reserve field parsing for OnRamp deployment
deployment/ccip/cs_test_helpers.go	Added Reserve value to test helper configuration
deployment/ccip/config/deploy.go	Added Reserve field to OnRampParams
contracts/wrappers/ccip/OnRamp.ts	Implemented withdrawFeeTokens message codec and updated DynamicConfig type
contracts/tests/ccip/router/Router.Setup.ts	Added reserve field to OnRamp deployment setup
contracts/tests/ccip/onramp/OnRamp.withdrawFeeToken.spec.ts	Added comprehensive test coverage for withdrawFeeTokens functionality
contracts/tests/ccip/onramp/OnRamp.spec.ts	Removed Withdrawable tests and updated deployment helper usage
contracts/tests/ccip/onramp/OnRamp.setDynamicConfig.spec.ts	Added reserve field to dynamic config tests
contracts/tests/ccip/onramp/OnRamp.send.spec.ts	Updated to use new setup function signature
contracts/tests/ccip/onramp/OnRamp.getFee.spec.ts	Updated to use new setup function signature
contracts/tests/ccip/onramp/OnRamp.generateMessageID.spec.ts	Updated to use new setup function signature
contracts/tests/ccip/onramp/OnRamp.executorExited.spec.ts	Updated to use new setup function signature
contracts/tests/ccip/onramp/OnRamp.applyDestChainConfigUpdates.spec.ts	Updated to use new setup function signature
contracts/tests/ccip/onramp/OnRamp.Setup.ts	Modified deployOnRampContract to return config object and updated setup function
contracts/contracts/ccip/onramp/types.tolk	Added reserve field to DynamicConfig struct
contracts/contracts/ccip/onramp/messages.tolk	Added OnRamp_WithdrawFeeTokens message and associated cost calculation
contracts/contracts/ccip/onramp/errors.tolk	Added UnknownToken and InsufficientValue error types
contracts/contracts/ccip/onramp/contract.tolk	Implemented onWithdrawFeetokens handler with reserve validation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[krebernisak]

We would also need amounts.

As this is an async env best option is the sender checks balances off-chain, sends amounts and we try to transfer to fee aggregator.

[patricios-space]

I wrote this taking only addresses to match EVM interface. However, Jetton wallets don't have onchain amount getters. We could keep a balance counter here, or accept amount as an argument