Skip to content

Conversation

@vicentevieytes
Copy link
Collaborator

No description provided.

@vicentevieytes vicentevieytes requested a review from a team as a code owner December 18, 2025 19:27
Copilot AI review requested due to automatic review settings December 18, 2025 19:27
@github-actions
Copy link

👋 vicentevieytes, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds validation to prevent invalid sequence number intervals in commit reports. The title indicates a fix for missing checks on sequence numbers in the offramp commit report.

  • Adds validation to ensure minSeqNr matches the source chain config and minSeqNr <= maxSeqNr
  • Implements previously stubbed load methods for deserializing commit report data structures
  • Adds comprehensive test coverage for the new validation rules

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/ccip/bindings/offramp/offramp.go Adds ErrorInvalidInterval error constant
contracts/wrappers/ccip/OffRamp.ts Adds InvalidInterval error enum value and implements load methods for RampMessageHeader, Any2TVMRampMessage, ExecutionReport, and execute message
contracts/tests/ccip/OffRamp.spec.ts Adds two test cases validating the new sequence number interval checks
contracts/contracts/ccip/offramp/errors.tolk Adds InvalidInterval error to the error enum
contracts/contracts/ccip/offramp/contract.tolk Adds assertion to validate sequence number intervals in commit reports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vicentevieytes and others added 3 commits December 18, 2025 16:28
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@patricios-space patricios-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bundle this fix with the ones we are merging in PR #430?

@vicentevieytes
Copy link
Collaborator Author

vicentevieytes commented Dec 18, 2025

@patricios-space

Should we bundle this fix with the ones we are merging in #430?

If you think that's better we can do that. I don't think it's necessary.

@vicentevieytes vicentevieytes changed the title fix: add missing check for sequence numberss in commit report offramp fix: add missing check for sequence numbers in commit report offramp Dec 19, 2025
Copy link
Collaborator

@patricios-space patricios-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@vicentevieytes vicentevieytes merged commit 3fbfe4e into main Dec 19, 2025
35 checks passed
@vicentevieytes vicentevieytes deleted the vv/fix-offramp-commit-sequence-nr branch December 19, 2025 17:28
jadepark-dev added a commit that referenced this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants