-
Notifications
You must be signed in to change notification settings - Fork 4
[NONEVM-3263] Add ownable go bindings #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors ownership-related bindings by extracting the Ownable2Step struct from the common package into a dedicated ownable2step package. The new package provides a more comprehensive implementation including storage types, message types, exit codes, and getter functions for ownership management in TON smart contracts.
Key Changes:
- Created a new
ownable2steppackage with complete bindings for two-step ownership functionality - Replaced all references from
common.Ownable2Steptoownable2step.Storageacross the codebase - Added support for ownership transfer messages, error codes, and getter methods
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/ccip/bindings/ownable2step/types.go | Defines ownership message types, exit codes, and error constants |
| pkg/ccip/bindings/ownable2step/storage.go | Defines the Storage struct for two-step ownership state |
| pkg/ccip/bindings/ownable2step/reader.go | Implements getter functions for owner and pending owner with role prefixing |
| pkg/ccip/bindings/ownable2step/exitcode_string.go | Auto-generated stringer implementation for ExitCode enum |
| pkg/ccip/bindings/router/router.go | Updates Storage and RMNRemote to use ownable2step.Storage, adds RMNOwnableMessage type |
| pkg/ccip/bindings/router/reader.go | Adds getter functions for RMN owner and pending owner |
| pkg/ccip/bindings/common/common.go | Removes the Ownable2Step struct definition |
| pkg/ccip/model/router.go | Updates import and type references to use ownable2step.Storage |
| pkg/ccip/model/onramp.go | Updates import and type references to use ownable2step.Storage |
| pkg/ccip/model/offramp.go | Updates import and type references to use ownable2step.Storage |
| pkg/ccip/model/fee_quoter.go | Updates import and type references to use ownable2step.Storage |
| pkg/ccip/bindings/receiver/receiver.go | Updates import and type references to use ownable2step.Storage |
| pkg/ccip/bindings/onramp/onramp_test.go | Updates test cases to use ownable2step.Storage |
| pkg/ccip/bindings/onramp/onramp.go | Updates Storage struct to use ownable2step.Storage |
| pkg/ccip/bindings/offramp/offramp.go | Updates Storage struct to use ownable2step.Storage |
| pkg/ccip/bindings/feequoter/fee_quoter.go | Updates Storage struct to use ownable2step.Storage |
| pkg/bindings/mcms/mcms/types.go | Updates Data struct to use ownable2step.Storage |
| pkg/bindings/mcms/mcms/storage.go | Updates import and initializes Data with ownable2step.Storage |
| pkg/bindings/examples/counter/types.go | Updates ContractData to use ownable2step.Storage |
| integration-tests/txm/txm_test.go | Updates test setup to use ownable2step.Storage |
| integration-tests/tracetracking/integration_test.go | Updates test data initialization to use ownable2step.Storage |
| integration-tests/smoke/logpoller/helper/event_emitter.go | Updates contract data initialization to use ownable2step.Storage |
| deployment/mcms/sequence/deploy_mcms.go | Updates MCMS deployment to use ownable2step.Storage |
| deployment/ccip/sequence/deploy_ccip.go | Updates all CCIP contract deployments to use ownable2step.Storage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
krebernisak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
NONEVM-3263