-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Convert all storybook stories to typescript #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import spacing from '@material-ui/core/styles/spacing' | ||
|
||
export const theme = { | ||
declare module '@material-ui/core/styles/createPalette' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were resolved via https://material-ui.com/guides/typescript/#customization-of-theme. But could definitely use some eyes on this since I'm not familiar with CSS styling. @NavyAdmiral @rupurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Been annoying not having types for these
'@babel/plugin-proposal-export-namespace-from', | ||
'@babel/plugin-proposal-throw-expressions', | ||
'@babel/plugin-proposal-class-properties' | ||
overrides: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the only way I could get preset-env
options properly merged, for some reason I have to define it once within the preset
array then again within overrides->presets
. Could use some eyes here too @NavyAdmiral @rupurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm it boots up and works 🍷
import spacing from '@material-ui/core/styles/spacing' | ||
|
||
export const theme = { | ||
declare module '@material-ui/core/styles/createPalette' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Been annoying not having types for these
This PR adds proper typescript support to Storybook stories.
core-js@3.x