Skip to content

feat: add target name param to cre deploy changeset#3

Merged
ecPablo merged 6 commits intomainfrom
ecpablo/add-target-name-param
Apr 8, 2026
Merged

feat: add target name param to cre deploy changeset#3
ecPablo merged 6 commits intomainfrom
ecpablo/add-target-name-param

Conversation

@ecPablo
Copy link
Copy Markdown
Contributor

@ecPablo ecPablo commented Apr 8, 2026

This pull request introduces support for specifying a custom deployment target name in the CRE workflow deployment operation. It also adds a new GitHub Actions workflow for CI linting and testing. The main changes are grouped into two themes: deployment target customization and CI workflow setup.

Deployment target customization:

  • Added an optional TargetName field to the CREWorkflowDeployInput struct, allowing users to specify a custom deployment target; if not provided, it defaults to CREDeployTargetName (cld-deploy).
  • Introduced the resolveTargetName method to handle the logic for determining the effective target name.
  • Updated the workflow configuration and CLI argument construction to use the resolved target name instead of a hardcoded value. [1] [2] [3]

CI workflow setup:

  • Added a new GitHub Actions workflow file .github/workflows/pull-request-main.yml to run Go linting and tests on pull requests and merge groups targeting the main branch.

This comment was marked as resolved.

@ecPablo ecPablo force-pushed the ecpablo/add-target-name-param branch from adbe842 to 27ff8c3 Compare April 8, 2026 00:40
@ecPablo ecPablo requested a review from Copilot April 8, 2026 00:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cre/operations/workflow_deploy_test.go
ecPablo and others added 2 commits April 7, 2026 18:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ecPablo ecPablo requested a review from Copilot April 8, 2026 00:46
@ecPablo ecPablo changed the title feat: add target name param to cre deploy changeset & re0add CI feat: add target name param to cre deploy changeset Apr 8, 2026

This comment was marked as resolved.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This comment was marked as resolved.

ecPablo and others added 2 commits April 7, 2026 18:57
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This comment was marked as resolved.

Comment thread .tool-versions
@@ -1,4 +1,4 @@
golang 1.26.1
golang 1.25.7
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert to 1.25.7 until CLD domains are all bumped to avoid forcing consumers to bump

@@ -0,0 +1,38 @@
name: pull-request-main
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already approved and merged here: #2 but for some reason the base branch did not change to main when the dependent pr was merged

@ecPablo ecPablo marked this pull request as ready for review April 8, 2026 01:20
@ecPablo ecPablo requested a review from a team as a code owner April 8, 2026 01:20
@ecPablo ecPablo merged commit 8b25662 into main Apr 8, 2026
13 checks passed
jkongie added a commit that referenced this pull request May 6, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.0](cld-changesets-v0.0.1...cld-changesets-v0.1.0)
(2026-05-06)


### Features

* add "catalog create chain metadata" changeset
([#36](#36))
([c12bb51](c12bb51))
* add catalog create contract metadata changeset
([#27](#27))
([8ec1cbc](8ec1cbc))
* add CRE workflow deploy changeset and operation
([#1](#1))
([960fde1](960fde1))
* add target name param to cre deploy changeset
([#3](#3))
([8b25662](8b25662))
* fund mcms pdas
([#22](#22))
([821e542](821e542))
* **jobspec:** port jobspec changesets from chainlink
([#21](#21))
([0ce3f74](0ce3f74))
* link token
([#30](#30))
([07345c1](07345c1))
* **pkg:** add contract constants and Solana MCMS state loading
([#5](#5))
([6a2bbee](6a2bbee))
* port BuildProposalFromBatchesV2
([#24](#24))
([28d53d7](28d53d7))
* port run changeset from chainlink
([#32](#32))
([693922f](693922f))
* port solana grant role
([#33](#33))
([7eca5be](7eca5be))
* port token approve
([#40](#40))
([04130de](04130de))
* **port:** firedrill mcms with operations api refactor
([#25](#25))
([6d9010c](6d9010c))
* **solana:** add SOL funding helpers for deployer transfers
([#19](#19))
([63bebf8](63bebf8))
* **solana:** port over mcms pda loader
([#11](#11))
([7170ddc](7170ddc))


### Bug Fixes

* **aptos:** move state load
([#8](#8))
([de58102](de58102))
* **evm:** port state load evm funcs
([#9](#9))
([99279f1](99279f1))
* **state:** restore addressbook usage
([#17](#17))
([017cd5e](017cd5e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
Co-authored-by: James Kong <61834+jkongie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants