Skip to content

Fix: Remove 0x hex prefix in secrets digest #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothyF95 merged 2 commits into from
Apr 29, 2026
Merged

Fix: Remove 0x hex prefix in secrets digest #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
146471f
Fix
timothyF95 Apr 28, 2026
9207e1f
Fix test
timothyF95 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/secrets/common/browser_flow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func vaultPermissionForMethod(method string) (string, error) {
}

func digestHexString(digest [32]byte) string {
return "0x" + hex.EncodeToString(digest[:])
return hex.EncodeToString(digest[:])
}

// executeBrowserUpsert handles secrets create/update when the user signs in with their organization account.
Expand Down
2 changes: 1 addition & 1 deletion cmd/secrets/common/browser_flow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestVaultPermissionForMethod(t *testing.T) {
func TestDigestHexString(t *testing.T) {
var d [32]byte
copy(d[:], []byte{1, 2, 3})
assert.Equal(t, "0x0102030000000000000000000000000000000000000000000000000000000000", digestHexString(d))
assert.Equal(t, "0102030000000000000000000000000000000000000000000000000000000000", digestHexString(d))
}

// TestBrowserFlowPKCE checks PKCE S256 (RFC 7636) used by the browser secrets authorization step.
Expand Down
Loading