Skip to content

Refactor input validation in UpsertWorkflow function #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anirudhwarrier merged 2 commits into from
May 22, 2026
Merged

Refactor input validation in UpsertWorkflow function #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ade369
Refactor input validation in UpsertWorkflow function
anirudhwarrier May 22, 2026
be04386
fix test
anirudhwarrier May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions internal/client/privateregistryclient/privateregistryclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,8 @@ func validateUpsertWorkflowInput(input OffchainWorkflowInput) error {
if input.Status == "" {
return fmt.Errorf("status is required")
}
if input.Status != WorkflowStatusUnspecified &&
input.Status != WorkflowStatusActive &&
input.Status != WorkflowStatusPaused {
return fmt.Errorf("status must be one of %q, %q, %q", WorkflowStatusUnspecified, WorkflowStatusActive, WorkflowStatusPaused)
if input.Status != WorkflowStatusActive && input.Status != WorkflowStatusPaused {
return fmt.Errorf("status must be one of %q, %q", WorkflowStatusActive, WorkflowStatusPaused)
}
if input.WorkflowName == "" {
return fmt.Errorf("workflowName is required")
Expand Down
2 changes: 1 addition & 1 deletion internal/client/privateregistryclient/privateregistryclient_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func TestValidateUpsertWorkflowInput(t *testing.T) {
{
name: "invalid status",
input: OffchainWorkflowInput{WorkflowID: "wf", Status: "INVALID", WorkflowName: "w", BinaryURL: "b", DonFamily: "f"},
err: "status must be one of \"WORKFLOW_STATUS_UNSPECIFIED\", \"WORKFLOW_STATUS_ACTIVE\", \"WORKFLOW_STATUS_PAUSED\"",
err: "status must be one of \"WORKFLOW_STATUS_ACTIVE\", \"WORKFLOW_STATUS_PAUSED\"",
},
{
name: "workflowName exceeds max length",
Expand Down
Loading