Skip to content

Fix CleanLogMessage#508

Merged
yashnevatia merged 1 commit into
mainfrom
fix-simulate-lggr-cleanlog
Jun 30, 2026
Merged

Fix CleanLogMessage#508
yashnevatia merged 1 commit into
mainfrom
fix-simulate-lggr-cleanlog

Conversation

@yashnevatia

@yashnevatia yashnevatia commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Agent:

The intent is fine; the implementation was sloppy — no word boundary, so ts= matched inside lamports=, assets=, events=, metrics=, anywhere …ts= shows up as a substring. Same risk exists for level= (anything ending in level=, e.g. loglevel=), but ts= is the worst offender because it's only 3 characters and -rts$ / -ets$ / -its$ word endings are common.

The \b fix anchors each pattern to start at a word boundary — so only standalone ts=... fields get stripped, not substrings buried inside user content.

echo "lamports=5000000000" | grep -oE 'ts=\S+'
# prints: ts=5000000000   ← yep, that's what was getting stripped

@yashnevatia yashnevatia requested a review from a team as a code owner June 30, 2026 10:20
@github-actions

Copy link
Copy Markdown

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@yashnevatia yashnevatia added this pull request to the merge queue Jun 30, 2026
Merged via the queue into main with commit c7e485b Jun 30, 2026
18 checks passed
@yashnevatia yashnevatia deleted the fix-simulate-lggr-cleanlog branch June 30, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants