Fully update config var documentation#260
Merged
StephenFluin merged 1 commit intomainfrom Aug 10, 2021
Merged
Conversation
|
✔️ Deploy Preview for dreamy-villani-0e9e5c ready! 🔨 Explore the source changes: b204a8b 🔍 Inspect the deploy log: https://app.netlify.com/sites/dreamy-villani-0e9e5c/deploys/61127c70e69b2a00084930af 😎 Browse the preview: https://deploy-preview-260--dreamy-villani-0e9e5c.netlify.app |
PiotrTrzpil
requested review from
AnushV,
PatrickAlphaC,
StephenFluin and
alexroan
as code owners
PiotrTrzpil
commented
Jul 23, 2021
| - [GAS_UPDATER_ENABLED](#gas_updater_enabled) | ||
| - [GAS_UPDATER_TRANSACTION_PERCENTILE](#gas_updater_transaction_percentile) | ||
| - [ETH_GAS_LIMIT_DEFAULT](#eth_gas_limit_default) | ||
| - [ETH_GAS_LIMIT_TRANSFER](#eth_gas_limit_transfer) |
Contributor
Author
There was a problem hiding this comment.
these were duplicates
StephenFluin
suggested changes
Jul 27, 2021
Contributor
StephenFluin
left a comment
StephenFluin
left a comment
There was a problem hiding this comment.
This looks great! Can you squash and rebase the PR and we'll be able to merge it.
Contributor
Author
|
@StephenFluin I always squash when merging, via github button - would that be ok? I'll edit the commit description as well then. |
StephenFluin
approved these changes
Aug 10, 2021
StephenFluin
force-pushed
the
chore/ch10539/fully-update-config-var-docs
branch
from
5607655 to
62a5bed
Compare
Removed duplicates, add keeper, add gcp-weather, clarify deprecated, add multi-word and large responses.
StephenFluin
force-pushed
the
chore/ch10539/fully-update-config-var-docs
branch
from
62a5bed to
b204a8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.