Merged
Conversation
StephenFluin
force-pushed
the
stephen/v1-jobspec-deprecation
branch
from
af98de3 to
d568fad
Compare
|
✔️ Deploy Preview for dreamy-villani-0e9e5c ready! 🔨 Explore the source changes: b874af9 🔍 Inspect the deploy log: https://app.netlify.com/sites/dreamy-villani-0e9e5c/deploys/6113d8f72f4daa0007604c40 😎 Browse the preview: https://deploy-preview-292--dreamy-villani-0e9e5c.netlify.app |
StephenFluin
force-pushed
the
stephen/v1-jobspec-deprecation
branch
from
d568fad to
865f77c
Compare
Add two migration examples Update specs Add better docs for External Initiators Co-authored-by: Alex Roan <alex.roan@hotmail.com> Co-authored-by: connorwstein <connor.stein@mail.mcgill.ca> Co-authored-by: Stephen Fluin <stephen.fluin@gmail.com>
StephenFluin
force-pushed
the
stephen/v1-jobspec-deprecation
branch
from
865f77c to
b874af9
Compare
StephenFluin
requested review from
AnushV,
PatrickAlphaC and
alexroan
as code owners
Contributor
Author
|
@PatrickAlphaC can I can an approval from you? I believe @spooktheducks has already verbally approved this. |
Contributor
|
These are beautiful. Ideally we'd add somewhere that v1 jobs have the concept of initiators changed. Now there is only external initiators. Internal initiators are replaced by "job type" |
PatrickAlphaC
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@spooktheducks
This is a new PR with the 12 commits from #229 squashed and then all of my changes as a commit on top of it. I think this is ready to go. Take a look. If there aren't any objections or discussions, then I'll squash my commit into Sam's and we can get this merged ASAP.