Skip to content

Rinkeby migration and example cleanup#819

Merged
dwightjl merged 5 commits intosmartcontractkit:mainfrom
dwightjl:rinkeby-migration
Jun 29, 2022
Merged

Rinkeby migration and example cleanup#819
dwightjl merged 5 commits intosmartcontractkit:mainfrom
dwightjl:rinkeby-migration

Conversation

@dwightjl
Copy link
Contributor

@dwightjl dwightjl commented Jun 23, 2022

  • Update code examples from Kovan to Rinkeby
  • Remove OpenEthereum/Parity examples now that OpenEthereum is deprecated.
  • Remove code samples that are no longer included in the docs

Depends on the following PR: smartcontractkit/smart-contract-examples#16

@vercel
Copy link

vercel bot commented Jun 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
documentation ✅ Ready (Inspect) Visit Preview Jun 29, 2022 at 3:28PM (UTC)

@dwightjl
Copy link
Contributor Author

Squashed and rebased to main

Remove Parity examples, remove old samples
@@ -113,7 +113,7 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update this function (still using kovan)

function getHistoricalPrice() {
    document.getElementById('get-price-field').value = "loading...";
    const web3 = new Web3("https://kovan.infura.io/v3/34ed41c4cf28406885f032930d670036");
		const aggregatorV3InterfaceABI = [{"inputs":[],"name":"decimals","outputs":[{"internalType":"uint8","name":"","type":"uint8"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"description","outputs":[{"internalType":"string","name":"","type":"string"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"uint80","name":"_roundId","type":"uint80"}],"name":"getRoundData","outputs":[{"internalType":"uint80","name":"roundId","type":"uint80"},{"internalType":"int256","name":"answer","type":"int256"},{"internalType":"uint256","name":"startedAt","type":"uint256"},{"internalType":"uint256","name":"updatedAt","type":"uint256"},{"internalType":"uint80","name":"answeredInRound","type":"uint80"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"latestRoundData","outputs":[{"internalType":"uint80","name":"roundId","type":"uint80"},{"internalType":"int256","name":"answer","type":"int256"},{"internalType":"uint256","name":"startedAt","type":"uint256"},{"internalType":"uint256","name":"updatedAt","type":"uint256"},{"internalType":"uint80","name":"answeredInRound","type":"uint80"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"version","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"}];
		const addr = "0x9326BFA02ADD2366b30bacB125260Af641031331";
		const priceFeed = new web3.eth.Contract(aggregatorV3InterfaceABI, addr);

    // Valid roundId must be known. They are NOT incremental.
    let validId = BigInt("18446744073709562301");
    priceFeed.methods.getRoundData(validId).call()
      .then((historicalRoundData) => {
        document.getElementById('get-price-field').value = historicalRoundData.answer;
     	})
  }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving those endpoint URLs alone for now. I need to get another endpoint started that we can use in the docs.

dwightjl and others added 2 commits June 29, 2022 08:00
Co-authored-by: Amine E. <aelmanaa@users.noreply.github.com>
@dwightjl dwightjl requested a review from aelmanaa June 29, 2022 14:02
@dwightjl dwightjl linked an issue Jun 29, 2022 that may be closed by this pull request
@dwightjl dwightjl merged commit 82f4455 into smartcontractkit:main Jun 29, 2022
@dwightjl dwightjl deleted the rinkeby-migration branch February 7, 2023 01:15
dev-dist added a commit that referenced this pull request Feb 23, 2026
* httpConf secrets clarification (#3476)

* Clarify token receiver security pattern for PTT to Solana (#3469)

* Migrate from Gelato guide (#3477)

* migrate from Gelato guide

* update sidebar

* update sidebar

* update sidebar

---------

Co-authored-by: Karim H. <98668332+khadni@users.noreply.github.com>
Co-authored-by: Syed Asad Kazmi <36279345+SyedAsadKazmi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Getting Help URL Mismatch

2 participants