Export ProviderRequestConfig & WebsocketTransportGenerics #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boxhock
changed the title
amit-momin
approved these changes
Jan 26, 2023
Contributor
|
I feel like this change is more of a patch. Looks like the labels defaulted to feature/minor |
Contributor
Author
|
@amit-momin Speaking strictly from Semver, a minor version bump would be the right thing, as we're adding types that consumers can use. A patch version change should be backwards compatible, which this is not. What do you think? |
Contributor
You're right! Minor makes more sense. I'll change it back |
Contributor
|
🚀 Successfully created version bump PR: #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to export ProviderRequestConfig previously, now we don't. This PR we don't don't export.
It helps typing EAs.