Add "noUncheckedIndexedAccess": true to compilerOptions#744
Merged
Conversation
Contributor
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
mxiao-cll
approved these changes
Apr 22, 2026
Contributor
|
🚀 Successfully created version bump PR: #745 |
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in the iTick EA that could have been caught by the compiler if the compiler had realized that
someArray[0]isundefinedif the array is empty. But the compiler doesn't do that unlessnoUncheckedIndexedAccessis enabled.If we change the generator template, we can make sure this option is enabled by default in future EAs.
Changes
"noUncheckedIndexedAccess": trueto"compilerOptions": {inscripts/generator-adapter/generators/app/templates/tsconfig.json.Tested
In external-adapters-js:
yarn newand follow the instructions.abcd.packages/sources/abcd/tsconfig.json.