Allow FEED_ID_JSON in makeStub#812
Merged
Merged
Conversation
Contributor
NPM Publishing labels 🏷️🔵 This PR has the |
dskloetc
force-pushed
the
kloet/allow-feed-id-json
branch
from
74cd577 to
3d45123
Compare
mxiao-cll
reviewed
Jun 5, 2026
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| EXTERNAL_ADAPTER_GENERATOR_NO_INTERACTIVE: 'true' | ||
| EXTERNAL_ADAPTER_GENERATOR_STANDALONE: 'true' | ||
| EXTERNAL_ADAPTER_GENERATOR_USE_LOCAL_FRAMEWORK_VERSION: 'true' |
Contributor
There was a problem hiding this comment.
When would this be false?
Contributor
Author
There was a problem hiding this comment.
When you generate a real new adapter in external-adapters-js.
Then it uses the published framework version.
mxiao-cll
approved these changes
Jun 5, 2026
Contributor
|
🚀 Successfully created version bump PR: #813 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#808 breaks a lot of tests that use
makeStub.makeStubis a convenient way in tests to check that every field on a stub object that is being accessed is specified in the test.The above PR added an extra field to
adapterSettingswhich is always being accessed, but not specified in any test.So all tests that use
makeStubwithadapterSettingswill now fail.This includes the generated example adapter in this very repo.
So currently CI is failing on every PR.
This wasn't caught on the breaking PR itself, because the generated example adapter uses the published framework version so it only started failing when a new framework version was published.
Changes
FEED_ID_JSONto the list of fields thatmakeStubis allowed to access even if it's not specified.