add timelock executor interface + evm implementation#210
Conversation
🦋 Changeset detectedLatest commit: b0cb6df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| return "", err | ||
| } | ||
|
|
||
| calls := make([]bindings.RBACTimelockCall, len(bop.Transactions)) |
There was a problem hiding this comment.
nitpick: You probably want this and we save a bunch of initialisations
| calls := make([]bindings.RBACTimelockCall, len(bop.Transactions)) | |
| calls := make([]bindings.RBACTimelockCall, 0, len(bop.Transactions)) |
There was a problem hiding this comment.
hm actually, I made this change and it caused tests to start failing with index out of bound
There was a problem hiding this comment.
you'd need to change the calls[i] = bellow to calls = append(calls, ...).
It's a minor thing though. Let's proceed as is.
|
|
||
| // TimelockExecutor is an interface for executing scheduled timelock operations. | ||
| type TimelockExecutor interface { | ||
| Execute(bop types.BatchOperation, timelockAddress string, predecessor common.Hash, salt common.Hash) (string, error) |
There was a problem hiding this comment.
i wonder would the import from "github.com/ethereum/go-ethereum/common" for Hash would cause any issue once we start supporting solana for mcms?
There was a problem hiding this comment.
I don't think so, because its just a [32]byte array, which is the output of any keccack256 hash function which is a prerequisite to supporting MCMS on any chain
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.5.0 ### Minor Changes - [#214](#214) [`04cb547`](04cb547) Thanks [@akhilchainani](https://github.com/akhilchainani)! - Add helper function for timelock proposal execution - [#210](#210) [`8431019`](8431019) Thanks [@akhilchainani](https://github.com/akhilchainani)! - Implement timelock executor interface + EVM implementation Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
3 participants
Below is a summarization created by an LLM (gpt-4o-2024-08-06). Be mindful of hallucinations and verify accuracy.
Why
Implementing a timelock executor interface and its EVM implementation enhances the system's ability to manage scheduled operations on EVM chains. This addition provides a structured approach to execute batch operations with timelock contracts, improving the system's functionality and reliability.
What