feat: add TimelockProposal.Convert for Solana#242
Merged
Conversation
🦋 Changeset detectedLatest commit: 431e921 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
feat-solana-timelock-converter
branch
2 times, most recently
from
fec9b5e to
291a250
Compare
gustavogama-cll
changed the title
TimelockProposal.Convert for Solana
gustavogama-cll
force-pushed
the
feat-solana-timelock-converter
branch
3 times, most recently
from
11b5cee to
b4fa31b
Compare
gustavogama-cll
force-pushed
the
feat-solana-timelock-converter
branch
2 times, most recently
from
7b91053 to
59ba342
Compare
gustavogama-cll
changed the title
TimelockProposal.Convert for SolanaTimelockProposal.Convert for Solana
gustavogama-cll
commented
Jan 24, 2025
|
|
||
| type AdditionalFields struct { | ||
| Accounts []*solana.AccountMeta `json:"accounts" validate:"required"` | ||
| Value *big.Int `json:"value" validate:"omitempty"` |
Contributor
Author
There was a problem hiding this comment.
I opted to add the Value attribute to AdditionalFields for consistency's sake. And in the hopes we'll eventually learn how to do direct SOL transfers.
If it's already been decided that this is out-of-scope, I'll undo this part.
Collaborator
There was a problem hiding this comment.
I think this should be good I also like both chain families having the value field to standardize the API
gustavogama-cll
force-pushed
the
feat-solana-timelock-converter
branch
from
59ba342 to
690425e
Compare
Contributor
Author
|
There's a lot of refactoring that we can do -- particularly in the e2e tests -- once this is merged. But I'm holding back for now to reduce the PR size. Maybe in the next one. |
ecPablo
previously approved these changes
Jan 24, 2025
ecPablo
left a comment
ecPablo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! 🔥 left some minor comments and questions but overall looks great!
|
|
||
| type AdditionalFields struct { | ||
| Accounts []*solana.AccountMeta `json:"accounts" validate:"required"` | ||
| Value *big.Int `json:"value" validate:"omitempty"` |
Collaborator
There was a problem hiding this comment.
I think this should be good I also like both chain families having the value field to standardize the API
Implement the Convert function for the Solana blockchain. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1420
gustavogama-cll
force-pushed
the
feat-solana-timelock-converter
branch
from
af3bf48 to
a350af8
Compare
Contributor
Author
|
Rebased due to conflicts, so needs another approval |
|
ecPablo
approved these changes
Jan 28, 2025
Merged
akhilchainani
pushed a commit
that referenced
this pull request
Jan 28, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.6.0 ### Minor Changes - [#256](#256) [`45c6a2e`](45c6a2e) Thanks [@akhilchainani](https://github.com/akhilchainani)! - Allow callProxy execute capability - [#245](#245) [`7a5944e`](7a5944e) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add context and Converter map TimelockConverter.Convert params - [#231](#231) [`a8447e1`](a8447e1) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): timelock inspection - operation statuses check - [#242](#242) [`c610826`](c610826) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add TimelockProposal.Convert for solana - [#238](#238) [`abde70c`](abde70c) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): implement get roles for timelock inspection - [#236](#236) [`150a1f6`](150a1f6) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - Use string for inspector return type - [#209](#209) [`a71dd79`](a71dd79) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add the `Configurer` component and `SetConfig` call to the Solana SDK. - [#223](#223) [`4adb968`](4adb968) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add a "context" parameter to all APIs that interact with a blockchain. - [#227](#227) [`21d8809`](21d8809) Thanks [@ecPablo](https://github.com/ecPablo)! - Adds Execute functionality to solana SDK - [#248](#248) [`e153c75`](e153c75) Thanks [@ecPablo](https://github.com/ecPablo)! - Timelock execute batch on solana SDK. - [#211](#211) [`be76399`](be76399) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): support get opdata, root and root metadata ### Patch Changes - [#215](#215) [`9f39403`](9f39403) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add the `Executor` component and `SetRoot` call to the Solana SDK. - [#259](#259) [`a4bc13b`](a4bc13b) Thanks [@anirudhwarrier](https://github.com/anirudhwarrier)! - usbwallet: fix ledger access for latest firmware and add Ledger Flex - [#225](#225) [`7c9cd3d`](7c9cd3d) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add PDA finders and ContractAddress parser to the Solana SDK - [#258](#258) [`a11a0ee`](a11a0ee) Thanks [@akhilchainani](https://github.com/akhilchainani)! - non-breaking change to allow a salt override to proposals - [#228](#228) [`b953973`](b953973) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(solana): setProgramID on inspection methods Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Convert function for the Solana blockchain.
A small modification to the contract was needed because in Solana we need the address of the mcm contract in order to extract the signer PDA and set it in some of the instructions.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1420