feat: add IsOperationDone and IsChainDone to timelock executable#337
Merged
gustavogama-cll merged 1 commit intomainfrom Mar 14, 2025
Merged
feat: add IsOperationDone and IsChainDone to timelock executable#337gustavogama-cll merged 1 commit intomainfrom
gustavogama-cll merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: c817685 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
ggama/chore-add-ischaindone
branch
from
46d3fe1 to
c817685
Compare
|
ChrisAmora
approved these changes
Mar 14, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.15.0 ### Minor Changes - [#337](#337) [`3965c2d`](3965c2d) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat: add IsOperationDone and IsChainDone to TimelockExecutable Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
ecPablo
pushed a commit
that referenced
this pull request
Mar 21, 2025
In order to support concurrent timelock executions between the chainlink-deployments CI and the legacy timelock-worker service, the GHA running on the CI need to be able to check if an operation and/or the operations of a chain have been marked as "done" by the timelock worker. This PR adds two methods to the TimelockExecutable type, implementing these two checks. The implementation was adapted from the existing methods: `IsOperationReady` and `IsChainReady`. JIRA: [DPA-1613](https://smartcontract-it.atlassian.net/browse/DPA-1613) [DPA-1613]: https://smartcontract-it.atlassian.net/browse/DPA-1613?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
ecPablo
pushed a commit
that referenced
this pull request
Mar 21, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.15.0 ### Minor Changes - [#337](#337) [`3965c2d`](3965c2d) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat: add IsOperationDone and IsChainDone to TimelockExecutable Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support concurrent timelock executions between the chainlink-deployments CI and the legacy timelock-worker service, the GHA running on the CI need to be able to check if an operation and/or the operations of a chain have been marked as "done" by the timelock worker.
This PR adds two methods to the TimelockExecutable type, implementing these two checks. The implementation was adapted from the existing methods:
IsOperationReadyandIsChainReady.JIRA: DPA-1613