Skip to content

fix(solana): use smaller batch size for the "appendSigner" instructions #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavogama-cll merged 1 commit into from
May 14, 2025
Merged

fix(solana): use smaller batch size for the "appendSigner" instructions #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-trains-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smartcontractkit/mcms": patch
---

fix(solana): use smaller batch size for the "appendSigner" instructions
4 changes: 3 additions & 1 deletion sdk/solana/configurer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import (

var _ sdk.Configurer = &Configurer{}

const maxAppendSignerBatchSize = 20 // REVIEW: run chunking tests to verify actual limit

// Configurer configures the MCM contract for Solana chains.
type Configurer struct {
instructionCollection
Expand Down Expand Up @@ -165,7 +167,7 @@ func (c *Configurer) preloadSigners(
return err
}

for i, chunkIndex := range chunkIndexes(len(signerAddresses), config.MaxAppendSignerBatchSize) {
for i, chunkIndex := range chunkIndexes(len(signerAddresses), maxAppendSignerBatchSize) {
err = c.addInstruction(fmt.Sprintf("appendSigners%d", i), bindings.NewAppendSignersInstruction(mcmName,
signerAddresses[chunkIndex[0]:chunkIndex[1]], configPDA, configSignersPDA, c.authorityAccount))
if err != nil {
Expand Down
Loading