feat: improve error message for check quorum to show offending signature#500
Merged
Conversation
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
🦋 Changeset detectedLatest commit: 4c3f966 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # errors.go
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
|
gustavogama-cll
approved these changes
Oct 14, 2025
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.27.0 ### Minor Changes - [#500](#500) [`dc330c2`](dc330c2) Thanks [@ecPablo](https://github.com/ecPablo)! - improve error message for check quorum to show offending signature ### Patch Changes - [#502](#502) [`c883009`](c883009) Thanks [@rodrigombsoares](https://github.com/rodrigombsoares)! - fix the execution order of batch calls in Sui Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error reporting for quorum checks in the
@smartcontractkit/mcmspackage. The main enhancement is that error messages now include detailed information about which specific signature caused a failure, making debugging easier and more precise.Error handling improvements
InvalidSignatureAtIndexError, which provides detailed context about the offending signature, including its index, values, and recovery error if present. (errors.go)CheckQuorummethod insignable.goto useInvalidSignatureAtIndexErrorwhen a signature fails to recover, or when a recovered address is not a valid signer, so error messages point to the exact problematic signature. [1] [2]Minor codebase changes
slicespackage to aid in checking if recovered addresses are valid signers. (signable.go)Documentation
.changeset/mean-doodles-wave.md)