fix: partially revert #684 and remove OperationID from Op types#695
Merged
gustavogama-cll merged 1 commit intoApr 8, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 27ecfd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
ggama/fix/remove-operation-id-from-operation-types
branch
2 times, most recently
from
42069ac to
8cda97a
Compare
gustavogama-cll
force-pushed
the
ggama/fix/remove-operation-id-from-operation-types
branch
from
8cda97a to
27ecfd2
Compare
|
ChrisAmora
approved these changes
Apr 7, 2026
ecPablo
approved these changes
Apr 8, 2026
gustavogama-cll
deleted the
ggama/fix/remove-operation-id-from-operation-types
branch
Merged
gustavogama-cll
pushed a commit
that referenced
this pull request
Apr 8, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/mcms@0.40.1 ### Patch Changes - [#695](#695) [`5d0e94e`](5d0e94e) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix: partially revert #684 and remove OperationID from Op types Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request partially reverts a previous change (#684) by removing the
OperationIDfield from operation-related types and code paths.We received feedback from the CCIP team that the addition of the OperationID in #684 broke several tests in the core node repository as well as chainlink-ccip due to custom logic used in the test helpers which would manually overwrite a proposal's Salt. After reviewing this case and other code from mcms clients, we concluded that the current API is too "exposed" and simply doesn't enable caching of calculated values -- as implemented in the original PR -- without running into the aforementioned issues.
So, for now, we'll revert the change and adopt a different strategy to associate proposal operations with changesets.