feat: [NONEVM-4520] ContractTypeAndVersion in OperationMetadata by patricios-space · Pull Request #751 · smartcontractkit/mcms

patricios-space · 2026-05-14T13:19:44Z

Depends on:

[NONEVM-4520] ref: FullyQualifiedName in root module chainlink-ton#741

feat: update cl-ton import

Copilot

Pull request overview

Adds a new ContractTypeAndVersion field to OperationMetadata so the TON SDK can carry a fully-qualified contract type-and-version string alongside the existing short ContractType. Call sites in the TON SDK (transaction creation, timelock converter/configurer, MCMS configurer) and tests are updated to populate it, and the TON decoder is migrated to the new tvm.ContractTLBRegistry / tvm.FullyQualifiedName types from the bumped chainlink-ton dependency. go.mod/go.sum are bumped accordingly.

Changes:

Add ContractTypeAndVersion field to types.OperationMetadata and a corresponding parameter to ton.NewTransaction.
Switch TON decoder/decoded operation to tvm.ContractTLBRegistry and tvm.FullyQualifiedName, and start using bindings.ShortRBAC/ShortTimelock/ShortMCMS and bindings.TypeRBAC/TypeTimelock/TypeMCMS constants instead of the hardcoded "RBACTimelock"/"MCMS" strings.
Bump chainlink-ton (and many transitive deps) in go.mod/go.sum.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
types/operation.go	Adds `ContractTypeAndVersion` field to `OperationMetadata`.
sdk/ton/transaction.go	Threads new `contractTypeAndVersion` parameter through `NewTransaction`.
sdk/ton/timelock_converter.go	Uses `bindings.ShortTimelock` / `TypeTimelock` and passes the new TAV string.
sdk/ton/timelock_configurer.go	Same update for the `UpdateDelay` skip-send path; reorganizes imports.
sdk/ton/configurer.go	Uses `bindings.ShortMCMS` / `TypeMCMS` for the `SetConfig` skip-send path.
sdk/ton/decoder.go	Switches to `tvm.ContractTLBRegistry` and `tvm.FullyQualifiedName`.
sdk/ton/decoded_operation.go	`DecodedOperation.ContractType` becomes `tvm.FullyQualifiedName`.
sdk/ton/decoder_test.go	Updates table to use `tvm.FullyQualifiedName` and binding constants.
sdk/ton/decoded_operation_test.go	Renames `contractType` → `contractFQN` and updates type.
sdk/ton/timelock_converter_test.go	Updates fixtures to use binding constants and the new field.
sdk/ton/encoder_test.go	Adds the new empty-string argument to `NewTransaction` calls.
go.mod / go.sum	Bumps `chainlink-ton` and many transitive dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

 	// Notice: EVM just sets 0 here, but on TON we need to set some value to cover gas fees
 	var tx types.Transaction
-	tx, err = NewTransaction(dstAddr, data.BeginParse(), t.amount.Nano(), "RBACTimelock", tags)
+	tx, err = NewTransaction(dstAddr, data.BeginParse(), t.amount.Nano(), bindings.ShortTimelock, string(bindings.TypeTimelock)+" 0.0.0", tags)


krebernisak · 2026-05-15T12:05:07Z

 					big.NewInt(0),
-					"RBACTimelock",
+					bindings.ShortTimelock,
+					string(bindings.TypeTimelock)+" 0.0.0",


Why this space, shouldn't this be @ sign?

TypeAndVersion.String() uses a space

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

 		"RBACTimelock",
+		string(bindings.TypeTimelock)+" 0.0.0",
 		[]string{"RBACTimelock", "GrantRole"},


 	// Notice: EVM just sets 0 here, but on TON we need to set some value to cover gas fees
 	var tx types.Transaction
-	tx, err = NewTransaction(dstAddr, data.BeginParse(), t.amount.Nano(), "RBACTimelock", tags)
+	tx, err = NewTransaction(dstAddr, data.BeginParse(), t.amount.Nano(), bindings.ShortTimelock, string(bindings.TypeTimelock)+" 0.0.0", tags)


-	ContractType string   `json:"contractType"`
-	Tags         []string `json:"tags"`
+	ContractType           string   `json:"contractType"`           // ContractType is the short type used in data store e.g. "Router". It represents the crosschain interface/expected behaviour of the destination contract.
+	ContractTypeAndVersion string   `json:"contractTypeAndVersion"` // ContractTypeAndVersion is the .String() representation of the TypeAndVersion of our contract. It is used for decoding the message data (cell) according to the correct TL-B schema. For example, in TON we use a FullyQualifiedName as the contract type. The resulting string looks like ""link.chain.ton.mcms.Timelock" 1.0.0".


cl-sonarqube-production · 2026-05-15T14:58:07Z

Quality Gate passed

Issues
3 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

 	// Notice: EVM just sets 0 here, but on TON we need to set some value to cover gas fees
 	var tx types.Transaction
-	tx, err = NewTransaction(dstAddr, data.BeginParse(), t.amount.Nano(), "RBACTimelock", tags)
+	tx, err = NewTransaction(dstAddr, data.BeginParse(), t.amount.Nano(), bindings.ShortTimelock, string(bindings.TypeTimelock)+" 0.0.0", tags)


gustavogama-cll · 2026-05-15T15:18:47Z

-	ContractType string   `json:"contractType"`
-	Tags         []string `json:"tags"`
+	ContractType           string   `json:"contractType"`           // ContractType is the short type used in data store e.g. "Router". It represents the crosschain interface/expected behaviour of the destination contract.
+	ContractTypeAndVersion string   `json:"contractTypeAndVersion"` // ContractTypeAndVersion is the .String() representation of the TypeAndVersion of our contract. It is used for decoding the message data (cell) according to the correct TL-B schema. For example, in TON we use a FullyQualifiedName as the contract type. The resulting string looks like "link.chain.ton.mcms.Timelock 1.0.0".


why not just Version?

also, I see the Copilot mentioning it's hardcoding -0.0.0. Why is it even added?

🤖 I have created a release *beep* *boop* --- ## [0.44.0](v0.43.0...v0.44.0) (2026-05-15) ### Features * [NONEVM-4520] ContractTypeAndVersion in OperationMetadata ([#751](#751)) ([16b18da](16b18da)) * support latest chain selectors in v1.0.100 ([#753](#753)) ([f5df18e](f5df18e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). [NONEVM-4520]: https://smartcontract-it.atlassian.net/browse/NONEVM-4520?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>

- feat: ContractVersion in OperationMetadata (#751) - feat: ContractFullyQualifiedName in TON's AdditionalFields - fix: revert ContractTypeAndVersion in OperationMetadata (#751) (16b18da)

🤖 I have created a release *beep* *boop* --- ## [0.45.0](v0.44.0...v0.45.0) (2026-05-18) ### Features * [NONEVM-4520] ContractVersion in OperationMetadata ([#751](#751)) ([f2eaf56](f2eaf56)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). [NONEVM-4520]: https://smartcontract-it.atlassian.net/browse/NONEVM-4520?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>

patricios-space added 2 commits May 14, 2026 09:41

feat: add ContractTypeAndVersion to OperationMetadata

59fab05

feat: update cl-ton import

fix: bump import

8c6e52e

patricios-space mentioned this pull request May 14, 2026

[NONEVM-4520] feat: ContractTypeAndVersion in upf smartcontractkit/chainlink-deployments-framework#979

Merged

patricios-space added 2 commits May 14, 2026 11:25

fix: missing version in NewTransaction

af6cc47

fix: bump import

9677431

patricios-space mentioned this pull request May 14, 2026

[NONEVM-4520] ref: FullyQualifiedName in deployment module smartcontractkit/chainlink-ton#742

Open

patricios-space requested a review from Copilot May 14, 2026 14:39

Copilot started reviewing on behalf of patricios-space May 14, 2026 14:40 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread sdk/ton/timelock_converter.go

Comment thread sdk/ton/transaction.go

Merge branch 'main' into feat/OperationMetadata.ContractTypeAndVersion

4c58449

patricios-space changed the title ~~[NONEVM-4520] feat: ContractTypeAndVersion in OperationMetadata~~ feat: [NONEVM-4520] ContractTypeAndVersion in OperationMetadata May 14, 2026

patricios-space added 2 commits May 14, 2026 12:08

fix: missing key in expected output

8156aa5

fix: ton e2e

4ad57fc

patricios-space marked this pull request as ready for review May 14, 2026 21:14

Copilot AI review requested due to automatic review settings May 14, 2026 21:14

patricios-space requested a review from a team as a code owner May 14, 2026 21:14

product-security-plaid-production Bot requested a review from gustavogama-cll May 14, 2026 21:14

patricios-space requested review from krebernisak and vicentevieytes May 14, 2026 21:14

Copilot AI reviewed May 14, 2026

View reviewed changes

fix: bump import to merged commit

a66dc27

krebernisak previously approved these changes May 15, 2026

View reviewed changes

fix: address comments

8a4e9d2

Copilot AI review requested due to automatic review settings May 15, 2026 12:45

patricios-space dismissed krebernisak’s stale review via 8a4e9d2 May 15, 2026 12:45

patricios-space requested a review from krebernisak May 15, 2026 12:45

Copilot started reviewing on behalf of patricios-space May 15, 2026 12:46 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

fix: apply suggestions

2b9141d

patricios-space enabled auto-merge (squash) May 15, 2026 13:51

ecPablo approved these changes May 15, 2026

View reviewed changes

Merge branch 'main' into feat/OperationMetadata.ContractTypeAndVersion

fd788e5

Copilot AI review requested due to automatic review settings May 15, 2026 14:55

Copilot started reviewing on behalf of patricios-space May 15, 2026 14:56 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

patricios-space merged commit 16b18da into main May 15, 2026
24 checks passed

patricios-space deleted the feat/OperationMetadata.ContractTypeAndVersion branch May 15, 2026 15:05

app-token-issuer-engops Bot mentioned this pull request May 15, 2026

chore(main): release 0.44.0 #754

Merged

gustavogama-cll reviewed May 15, 2026

View reviewed changes

patricios-space mentioned this pull request May 18, 2026

feat: [NONEVM-4520] ContractVersion in OperationMetadata (#751) #755

Merged

app-token-issuer-engops Bot mentioned this pull request May 18, 2026

chore(main): release 0.45.0 #756

Merged

This was referenced May 19, 2026

[NONEVM-4520] ref: FullyQualifiedName in deployment module smartcontractkit/chainlink-ton#743

Draft

[NONEVM-4520] ref: FullyQualifiedName in deployment module smartcontractkit/chainlink-ton#744

Closed

fix: bump imports smartcontractkit/chainlink#22545

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [NONEVM-4520] ContractTypeAndVersion in OperationMetadata#751

feat: [NONEVM-4520] ContractTypeAndVersion in OperationMetadata#751
patricios-space merged 11 commits into
mainfrom
feat/OperationMetadata.ContractTypeAndVersion

patricios-space commented May 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

krebernisak May 15, 2026

Uh oh!

patricios-space May 15, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

cl-sonarqube-production Bot commented May 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

gustavogama-cll May 15, 2026

Uh oh!

gustavogama-cll May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

patricios-space commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

krebernisak May 15, 2026

Choose a reason for hiding this comment

Uh oh!

patricios-space May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

cl-sonarqube-production Bot commented May 15, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

gustavogama-cll May 15, 2026

Choose a reason for hiding this comment

Uh oh!

gustavogama-cll May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

patricios-space commented May 14, 2026 •

edited

Loading