Skip to content

Conversation

@SyedAsadKazmi
Copy link
Collaborator

@SyedAsadKazmi SyedAsadKazmi commented Oct 29, 2025

This pull request makes several improvements to the foundry scripting utilities and documentation for cross-chain token and pool management. The most significant changes are the removal of the HelperUtils dependency in favor of using methods directly from HelperConfig, the addition of Optimism Sepolia network support, and updates to naming conventions and documentation for consistency and clarity.

Key changes:

Helper utilities refactor and simplification:

  • Removed the HelperUtils import and updated all scripts to use the new getNetworkConfig and getChain methods directly from HelperConfig, simplifying code and reducing indirection. (ccip/cct/foundry/script/AddRemotePool.s.sol, ccip/cct/foundry/script/RemoveRemotePool.s.sol, ccip/cct/foundry/script/GetCurrentRateLimits.s.sol, ccip/cct/foundry/script/AcceptAdminRole.s.sol, ccip/cct/foundry/script/ApplyChainUpdates.s.sol, ccip/cct/foundry/script/ClaimAdmin.s.sol, ccip/cct/foundry/script/DeployBurnMintTokenPool.s.sol, ccip/cct/foundry/script/DeployLockReleaseTokenPool.s.sol, ccip/cct/foundry/script/DeployToken.s.sol, ccip/cct/foundry/script/MintTokens.s.sol[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Network configuration enhancements:

  • Added support for the Optimism Sepolia network in HelperConfig, including a new configuration function and handling for the associated chain ID. Also added a general getNetworkConfig function to retrieve network configurations by chain ID. (ccip/cct/foundry/script/HelperConfig.s.sol[1] [2] [3]

Documentation and naming consistency:

  • Updated all references in README.md and script output paths to use the new chain alias naming convention (e.g., avalanche_fuji instead of avalancheFuji, arbitrum_one_sepolia instead of arbitrumSepolia). This ensures consistency between code, configuration, and documentation. (ccip/cct/foundry/README.md[1] [2] [3] [4] [5] [6] [7] [8]

These changes improve maintainability, clarity, and extensibility of the foundry scripting environment for cross-chain token operations.

@SyedAsadKazmi SyedAsadKazmi requested a review from a team as a code owner October 29, 2025 18:44
@github-actions
Copy link

👋 SyedAsadKazmi, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@aelmanaa aelmanaa merged commit 4105524 into main Oct 30, 2025
9 checks passed
@aelmanaa aelmanaa deleted the cct-foundry-refactor branch October 30, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants