Conversation
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
erikburt
reviewed
Jun 16, 2026
Comment on lines
+56
to
+65
| if len(b) == 0 { | ||
| return "" | ||
| } | ||
| s, ok := i.m[string(b)] | ||
| if ok { | ||
| return s | ||
| } | ||
| s = string(b) | ||
| i.m[s] = s | ||
| return s |
Collaborator
Author
There was a problem hiding this comment.
No. There's now 1 stringInterner per Analyze call, so multiple' Analyze' calls won't access it in parallel. And the Analyze loops over it sequentially, so no mutex is needed.
erikburt
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzeon large test results would hit OOM errors. This breaks up the function, and uses https://github.com/buger/jsonparser for speed + memory efficiency.