Conversation
The singleflight `.finally()` chain created a dangling promise with no
error handler. When `authenticateWithRefreshToken` rejected (e.g. expired
session), the finally chain re-rejected independently of the awaited
consumer, tripping unhandledRejection and crashing the process.
Attach `.catch(() => {})` to the cleanup chain. The awaited consumer
still owns the real error handling.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yasirali179
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.catch(() => {})to the singleflight.finally()chain inservices/actions/src/auth/token.jsso cleanup cannot produce a dangling rejected promise.Context
Observed in production (synmetrix k8s ns): both
synmetrix-actionsreplicas crashed with exit 1 when WorkOS returnedinvalid_grant — Session has already endedfromauthenticateWithRefreshToken. Stack pointed atsrc/auth/token.js:66.Root cause: the singleflight pattern stored the refresh promise, then called
refreshPromise.finally(() => inflightRefreshes.delete(sessionId))on a separate statement. That.finally()returns a new promise which re-rejects if the source rejects. No handler was attached to it, sounhandledRejectionfired even thoughawait refreshPromiseinside the try/catch handled its own chain.Test plan
/auth/tokenreturns 200 with clearedworkosAccessToken(falls through to existing Hasura JWT path).🤖 Generated with Claude Code