fix: reduce logs during streaming #1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time SDL Core receives a video packet from mobile, it generates a large amount of logs. Instead of completely removing them, this commit decreases their levels to TRACE. Head unit systems with video streaming feature can set log output level to DEBUG (or higher) to get rid of the logs.
Contributor
Author
|
@JackLivio @jacobkeeler Please kindly review. |
Collaborator
|
@shoamano83 I like this change. Could you please retarget for the 4.4.0 release candidate branch? I would like to put this into the next release since most of the new features revolve around video streaming. |
Collaborator
|
@shoamano83 We are still discussing if these logs are needed at all, or if trace is the best log level for these logs. |
Contributor
Author
|
Thanks for your comment. Let me know if you want to remove some of the logs, I will update PR accordingly. |
|
Can one of the admins verify this patch? |
jacobkeeler
approved these changes
Feb 13, 2018
jacobkeeler
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1777.
I thought that removing particular logs completely will confuse developers and hence it will be a bad idea. So instead of eliminating logs, log levels are decreased.
Head unit systems with video streaming feature can set log output level to DEBUG (or higher) to get rid of the logs.