Fixed vrSynonyms and ttsName content in SystemRequest(QUERY_APPS) #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d upper bound values in json file
Ypostolov
requested review from
a user,
AByzhynar,
AKalinich-Luxoft,
BSolonenko,
IGapchuk,
LitvinenkoIra,
LuxoftAKutsan,
mked-luxoft and
mkorniichuk
AKalinich-Luxoft
approved these changes
Oct 18, 2018
mked-luxoft
approved these changes
Oct 18, 2018
IGapchuk
approved these changes
Oct 18, 2018
mkorniichuk
approved these changes
Oct 18, 2018
BSolonenko
approved these changes
Oct 28, 2018
LuxoftAKutsan
approved these changes
Nov 8, 2018
AByzhynar
approved these changes
Nov 9, 2018
LitvinenkoIra
approved these changes
Nov 22, 2018
ghost
approved these changes
Nov 28, 2018
Contributor
|
@Ypostolov Please update this PR to include changes from the latest develop |
…me_vrSynonyms_ttsName_case_of_bound_values_in_json
Contributor
|
@ShobhitAd Please find update in 49a4ec9 |
ShobhitAd
requested changes
Apr 23, 2021
src/components/application_manager/src/application_manager_impl.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/src/application_manager_impl.cc
Outdated
Show resolved
Hide resolved
…l.cc Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
…l.cc Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
Contributor
Author
|
@ShobhitAd File updated. Please check. |
dboltovskyi
suggested changes
May 4, 2021
| json::ttsName)) { | ||
| SDL_LOG_DEBUG("Get ttsName from default language"); | ||
| ttsName = | ||
| app_data[json::languages][default_idx][json::default_][json::ttsName]; |
Contributor
There was a problem hiding this comment.
@Ypostolov Please notice ttsName is an array according to the https://github.com/smartdevicelink/sdl_core/tree/develop/src/components/interfaces/HMI_API.xml#L2914.
However within fix we got non-array value, e.g.
"ttsName": "A",
In Json file it's defined as non-array, but it looks like we need to convert it to array with single element.
Contributor
Author
There was a problem hiding this comment.
@dboltovskyi
Fixed in ce8706b.
Please check regression.
ShobhitAd
approved these changes
May 11, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Covered by ATF script.
Summary
There was an issue SDL sends in BC.UpdateAppList in vrSynonyms and ttsName values taken from applications name. Was added logic to apply vrSynonyms and ttsName values from the json file in case when only default language settings are present.
CLA