Skip to content

Conversation

@KhrystynaDubovyk
Copy link
Contributor

@KhrystynaDubovyk KhrystynaDubovyk commented Jun 12, 2018

Technical task: #2172
Update Enums, Structs index with new Lights parameters.

@sdl-robot
Copy link

Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@yang1070
Copy link

@theresalech Ford approves this change. thanks

@LuxoftAKutsan LuxoftAKutsan force-pushed the feature/rc_lights_more_names_and_status_values branch from f7fa8ca to 8b30b6d Compare August 16, 2018 10:38
@sdl-robot
Copy link

@sdl-robot
Copy link

@sdl-robot
Copy link


|Name|Value|Description|
|:---|:----|:----------|
|AUDIO|0||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this DeactivateReason is related to status light values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackLivio, fixed 13acbe8

|driverBuckleBelted|Common.VehicleDataEventStatus|false|||
|leftRow2BuckleBelted|Common.VehicleDataEventStatus|false|||
|passengerChildDetected|Common.VehicleDataEventStatus|false|||
|passengerChildDetected|Common.VehicleVehicleDataEventStatus|false|||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Common.VehicleDataEventStatus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackLivio, fixed 4b3ac09

|radioEnable|Boolean|false||True if the radio is on, false is the radio is off|
|state|Common.RadioState|false||||
|sisData|Common.SisData|false||Read-only Station Information Service (SIS) data provides basic information about the station such as call sign, as well as information not displayable to the consumer such as the station identification number|
|hdRadioEnable|Boolean|false||True if the hd radio is on, false is the radio is off|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackLivio, solving conflict I removed the parameter thinking it is not related to status light values.
after investigation, it turned out the param was added and merged by earlier #pull/106.
added back f917f54

@sdl-robot
Copy link

@sdl-robot
Copy link

@sdl-robot
Copy link

@Jack-Byrne Jack-Byrne merged commit 4f9ecd0 into develop Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants