- 
                Notifications
    
You must be signed in to change notification settings  - Fork 24
 
Feature/RC lights more names and status values #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/RC lights more names and status values #107
Conversation
| 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/f7fa8ca602e43fb375e8101d6cfa2104106a74f7/overview/  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
| 
           @theresalech Ford approves this change. thanks  | 
    
f7fa8ca    to
    8b30b6d      
    Compare
  
    | 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/8b30b6da321e8ffc98966c72b6049f1da46df834/overview/  | 
    
| 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/8825632f689e0d85be0162169707d0f0610f1f02/overview/  | 
    
| 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/b4baa4a4c71016c1b4bdf3ca3c05165848a9348b/overview/  | 
    
        
          
                docs/Common/Enums/index.md
              
                Outdated
          
        
      | 
               | 
          ||
| |Name|Value|Description| | ||
| |:---|:----|:----------| | ||
| |AUDIO|0|| | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this DeactivateReason is related to status light values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackLivio, fixed 13acbe8
        
          
                docs/Common/Structs/index.md
              
                Outdated
          
        
      | |driverBuckleBelted|Common.VehicleDataEventStatus|false||| | ||
| |leftRow2BuckleBelted|Common.VehicleDataEventStatus|false||| | ||
| |passengerChildDetected|Common.VehicleDataEventStatus|false||| | ||
| |passengerChildDetected|Common.VehicleVehicleDataEventStatus|false||| | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo? Common.VehicleDataEventStatus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackLivio, fixed 4b3ac09
| |radioEnable|Boolean|false||True if the radio is on, false is the radio is off| | ||
| |state|Common.RadioState|false|||| | ||
| |sisData|Common.SisData|false||Read-only Station Information Service (SIS) data provides basic information about the station such as call sign, as well as information not displayable to the consumer such as the station identification number| | ||
| |hdRadioEnable|Boolean|false||True if the hd radio is on, false is the radio is off| | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackLivio, solving conflict I removed the parameter thinking it is not related to status light values.
after investigation, it turned out the param was added and merged by earlier #pull/106.
added back f917f54
| 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/13acbe8d0475d92bbd431d2bf48dce0cb53ea485/overview/  | 
    
| 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/4b3ac0992486809d519c739047368291b25a9304/overview/  | 
    
| 
           Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/f917f54c779c148ec6928936f871d7b60f4d6150/overview/  | 
    
Technical task: #2172
Update Enums, Structs index with new Lights parameters.