Skip to content

Conversation

@bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented May 24, 2021

Fixes #1692

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Core Tests

  1. Send a graphic of type persistent
  2. Send the same graphic with type non-persistent
  3. Kill the app
  4. Re-open and connect the app to the same Core instance (e.g. Manticore)
  5. Send the graphic with type non-persistent and confirm that the image appears

Core version / branch / commit hash / module tested against: Core 7.1.1
HMI name / version / branch / commit hash / module tested against: 0.10.0

Summary

This PR fixes an issue in FileManager.hasUploadedfile() method where it incorrectly returns false when the file is uploaded

CLA

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #1693 (cacb979) into develop (ad5fc1e) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

❗ Current head cacb979 differs from pull request most recent head 6c4da87. Consider uploading reports for the commit 6c4da87 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1693      +/-   ##
=============================================
- Coverage      54.15%   54.15%   -0.01%     
+ Complexity      5336     5334       -2     
=============================================
  Files            555      555              
  Lines          24582    24586       +4     
  Branches        3108     3111       +3     
=============================================
+ Hits           13313    13314       +1     
- Misses         10109    10113       +4     
+ Partials        1160     1159       -1     
Impacted Files Coverage Δ Complexity Δ
...smartdevicelink/managers/file/BaseFileManager.java 65.97% <14.28%> (-0.87%) 30.00 <2.00> (ø)
...ink/managers/screen/BaseTextAndGraphicManager.java 63.75% <0.00%> (-0.42%) 50.00% <0.00%> (-2.00%)
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (+1.21%) 5.00% <0.00%> (ø%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants