Skip to content

Conversation

@jordynmackool
Copy link
Contributor

@jordynmackool jordynmackool commented Oct 19, 2021

Fixes issue #1754

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below) - N/A; No testing is needed as this PR fixes spelling and grammar updates only.
  • I have run the unit tests with this PR - N/A; No testing is needed as this PR fixes spelling and grammar updates only.
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below). - N/A; No testing is needed as this PR fixes spelling and grammar updates only.*

Unit Tests

[Describe the unit tests and behaviors added in this PR] - N/A; No unit testing is needed as this PR fixes spelling and grammar updates only.

Core Tests

N/A; No testing is needed as this PR fixes spelling and grammar updates only.

Summary

Fixes existing spelling/ grammar errors in the Java Suite Documentation.

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • Fixes #2021

Tasks Remaining:

N/A

CLA

@jordynmackool jordynmackool changed the title Fixes issue #1754 Update spelling/ Grammar errors Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1755 (20ff78f) into develop (c3553b7) will decrease coverage by 0.31%.
The diff coverage is 47.02%.

❗ Current head 20ff78f differs from pull request most recent head b25de3a. Consider uploading reports for the commit b25de3a to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1755      +/-   ##
=============================================
- Coverage      54.46%   54.14%   -0.32%     
- Complexity      5408     5486      +78     
=============================================
  Files            555      562       +7     
  Lines          24746    25459     +713     
  Branches        3156     3315     +159     
=============================================
+ Hits           13477    13784     +307     
- Misses         10095    10419     +324     
- Partials        1174     1256      +82     
Impacted Files Coverage Δ
...evicelink/protocol/heartbeat/HeartbeatMonitor.java 14.56% <0.00%> (ø)
...icelink/transport/MultiplexBluetoothTransport.java 4.23% <0.00%> (-0.03%) ⬇️
...martdevicelink/transport/SdlBroadcastReceiver.java 3.04% <0.00%> (-0.18%) ⬇️
...link/transport/USBAccessoryAttachmentActivity.java 0.00% <0.00%> (ø)
...com/smartdevicelink/util/IntegrationValidator.java 0.00% <0.00%> (ø)
...agers/screen/menu/VoiceCommandUpdateOperation.java 76.37% <ø> (ø)
...va/com/smartdevicelink/protocol/BaseSdlPacket.java 71.42% <0.00%> (-0.58%) ⬇️
.../com/smartdevicelink/protocol/ProtocolMessage.java 60.60% <0.00%> (-0.94%) ⬇️
.../com/smartdevicelink/protocol/SdlProtocolBase.java 15.75% <0.00%> (+0.45%) ⬆️
...devicelink/proxy/rpc/AudioControlCapabilities.java 89.28% <ø> (ø)
... and 61 more

@jordynmackool jordynmackool changed the base branch from develop to release/5.3.0_RC October 25, 2021 20:24
@bilal-alsharifi bilal-alsharifi merged commit 4928327 into release/5.3.0_RC Oct 25, 2021
@bilal-alsharifi bilal-alsharifi deleted the Update-grammatical/spelling-errors branch October 25, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants