add best practices link and review info to PR template #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hotfix/4.7.2 #915 +/- ##
===============================================
Coverage 42.58% 42.58%
Complexity 3734 3734
===============================================
Files 434 434
Lines 23061 23061
Branches 2690 2690
===============================================
Hits 9820 9820
Misses 12597 12597
Partials 644 644Continue to review full report at Codecov.
|
BrettyWhite
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #913
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
Added SDL GitHub Best Practices link and review request information to pull_request_template.md, per issue #913 .
CLA