Add support for password protected archives#17
Merged
cabarnes merged 95 commits intosmartfile:masterfrom Aug 12, 2022
Merged
Conversation
Author
|
I Think i've fixed all issues |
cabarnes
reviewed
Aug 10, 2022
cabarnes
reviewed
Aug 10, 2022
cabarnes
suggested changes
Aug 11, 2022
cabarnes
reviewed
Aug 12, 2022
Member
cabarnes
left a comment
cabarnes
left a comment
There was a problem hiding this comment.
Everything looks good. Just a couple more little cleanups and then this should be good to merge
cabarnes
approved these changes
Aug 12, 2022
Member
cabarnes
left a comment
cabarnes
left a comment
There was a problem hiding this comment.
Thanks for all the hard work to add this feature!
Author
|
I'm having problem to use python-libarchive=4.1.0 on systems with libarchive.so.13 because |
Member
|
I am able to use it to create password protected archives on Ubuntu 20.04 and 22.04 without issue. They are using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request combines patches from https://github.com/richnetdesign/python-libarchive
And my work to implement handling of password protected archives and building against latest version of libachive