Skip to content

Conversation

@jmgurney
Copy link

This addresses issue #5 .

Copy link
Member

@cabarnes cabarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it that the entire file changed? Something needs to be fixed so that there is only a change for this issue

@jmgurney
Copy link
Author

The change that "changed everything" was e666329 . I have an objection to CR line endings when using git, as git will automatically check out using the correct line endings for text files.

If you look at 6d4fbd8 that is the change that fixed things.

Copy link
Member

@cabarnes cabarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@cabarnes cabarnes merged commit 70c2ecd into smartfile:master Sep 27, 2022
@jmgurney jmgurney deleted the detect_prefix branch September 27, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants