feat(agent): allow code-simplifier to read untracked files

[fdematos]

Summary

• Update code-simplifier agent to explicitly include untracked files in its scope
• Add instruction to read untracked file content before analyzing/simplifying
• Ensures new (uncommitted) files are properly analyzed during /simplify-changes

[opencode-agent]

Code Review Summary

Overall Assessment

The pull request introduces several improvements, particularly focusing on the code-simplifier agent's ability to handle untracked files. The changes are well-documented and align with the project's goals. However, there are a few areas that need attention.

Key Changes

1. Code-Simplifier Agent Update (agent/code-simplifier.md):

   • Explicitly includes untracked files in its scope.
   • Adds instruction to read untracked file content before analyzing/simplifying.
   • Clear and concise updates to the agent's documentation.

2. New Skill Addition (skill/ask-questions-if-underspecified/SKILL.md):

   • Introduces a new skill for clarifying requirements before implementation.
   • Well-structured with clear workflow and anti-patterns.

3. Documentation Updates (README.md, CHANGELOG.md):

   • Comprehensive updates to reflect new features and changes.
   • Improved clarity and organization.

Potential Issues and Suggestions

1. Code-Simplifier Agent

• Line 29-30 (agent/code-simplifier.md): The instruction to include untracked files is clear, but ensure the agent's implementation can handle cases where untracked files are not readable or accessible.
• Line 65-66: The execution process now includes reading untracked files. Ensure error handling is in place for cases where file reading fails.

2. Diff-Summary Command

• Line 46-48 (command/diff-summary.md): The note about untracked files is helpful. Consider adding a brief example or clarification on how to read these files directly.

3. Review-Changes Command

• Line 19-21 (command/review-changes.md): Similar to diff-summary, ensure consistency in how untracked files are handled and documented.

4. Skill Tool

• Line 128-213 (src/tools/skill.ts): The skill tool implementation is robust. Ensure that the caching mechanism (cachedSkills, cachedDescription) is thread-safe if the plugin supports concurrent operations.

5. General Documentation

• README.md: The updates are comprehensive, but ensure all new features are consistently documented. For example, the ask-questions-if-underspecified skill is mentioned but could benefit from a brief usage example.

Code Quality

• Consistency: The changes maintain consistency with the existing codebase.
• Clarity: Documentation and comments are clear and concise.
• Error Handling: Ensure robust error handling for file operations, especially for untracked files.

Recommendations

1. Testing: Verify that the code-simplifier agent correctly handles untracked files in various scenarios (e.g., empty files, unreadable files).
2. Documentation: Add a brief example in the README.md for the new ask-questions-if-underspecified skill.
3. Error Handling: Ensure that the skill tool's caching mechanism is thread-safe if concurrent operations are supported.

Overall, the pull request is well-prepared and introduces valuable features. With minor adjustments, it will be ready for merging.

opencode session  |  github run

[opencode-agent]

Here is my review of the pull request:

Code Quality Issues

1. README.md: The documentation is comprehensive but could benefit from a brief usage example for the new ask-questions-if-underspecified skill to help users understand how to activate and use it.

2. agent/code-simplifier.md: The instruction to include untracked files is clear, but there's no mention of error handling for cases where untracked files might not be readable or accessible. This should be addressed to ensure robustness.

3. command/diff-summary.md: The note about untracked files is helpful, but it would be beneficial to include a brief example or clarification on how to read these files directly, ensuring users know how to proceed.

4. command/review-changes.md: Similar to diff-summary, ensure consistency in how untracked files are handled and documented. The current note is clear but could be expanded for better user guidance.

Potential Bugs

1. Error Handling for Untracked Files: The code-simplifier agent now includes untracked files in its scope, but there's no explicit error handling for scenarios where these files might be unreadable or inaccessible. This could lead to runtime errors if not addressed.

2. Thread Safety in Skill Tool: If the plugin supports concurrent operations, the caching mechanism in the skill tool (cachedSkills, cachedDescription) should be reviewed for thread safety to prevent race conditions.

Suggestions for Improvement

1. Testing: Verify that the code-simplifier agent correctly handles untracked files in various scenarios, such as empty files, unreadable files, or files with special characters. This will ensure robustness and reliability.

2. Documentation Enhancement: Add a brief example in the README.md for the new ask-questions-if-underspecified skill to illustrate its usage and activation process. This will help users understand how to leverage this feature effectively.

3. Error Handling: Ensure that the skill tool's caching mechanism is thread-safe if concurrent operations are supported. This will prevent potential issues in multi-threaded environments.

Overall, the pull request introduces valuable features and improvements. With the suggested adjustments, it will be well-prepared for merging.

opencode session  |  github run