SMFI-1033: Disable certain rules for SwiftUI Projects#105
Merged
Conversation
added 5 commits
April 17, 2020 11:40
…o add these rules to the disabled rule set when the script is run and the --swiftUI flag is set
Tomusm
reviewed
Apr 21, 2020
| disabled_rules: | ||
| - multiple_closures_with_trailing_closure | ||
| - missing_closure_name | ||
| - missing_closure_datatype No newline at end of file |
Contributor
There was a problem hiding this comment.
missing_closure_datatype: is there situations where it cannot work with swiftUI ?
IMO it should be that way:
- either you use $0, no need for type
- or you declare the variable, then we need the type
-> Anyway Xcode is autocompleting the type
Tomusm
approved these changes
Apr 28, 2020
kmeinh
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
--SwiftUIflag is provided, the rules in the swiftlint+swiftUI.yml will not be used in the swift lint process.