Conversation
Contributor
|
12mb binary. that's quite big isn't? |
Contributor
Author
Yes. SwiftLint is 12.7MB too.
Done |
kevindelord
reviewed
Sep 23, 2020
|
|
||
| DrString is configured to run when you execute `Submodules/SMF-iOS-CommonProjectSetupFiles/setup-common-project-files.sh` with [framework target configuration](#setup) parameters. | ||
|
|
||
| **Make sure that `/.drstring.toml` is added to the gitignore file as the DrSwift configuration file be automatically copied from the repo into the projects base folder.** |
Contributor
There was a problem hiding this comment.
How could we do to not forget about this? How to remind developers about this?
Contributor
Author
There was a problem hiding this comment.
We can mention it in a weekly. I'm also very sure @Tomusm will notice when the FW PRs appear and .drstring.toml is checked it instead of an updated .gitignore.
Tomusm
approved these changes
Sep 23, 2020
kmeinh
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a new cool kid around the block:
https://github.com/dduan/DrString
It's only enable for framework projects