Skip to content

added support for debug mode #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmeinh merged 1 commit into from
Jun 21, 2019
+5 −6
Merged

added support for debug mode #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Sentry/SentrySDK+SMFLogger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,9 @@ class SentrySDK: NSObject {
/// This will setup the SentrySDK with the common base configuration. Crashes will be detected if the app is build with the release build type and the sentry dsn taken from the info plists.
///
/// - Parameters:
/// - configuration: sentry dsn string
/// - configuration: Configuration object
static func setup(configuration: SentrySDK.Configuration) {

// Make sure SentrySDK is not setup in a debug build
guard (self.isDebugBuild == false) else {
// Configure SentrySDK only for non debug builds or if the exception flag is set to true
guard (self.isDebugBuild == false || configuration.enableDebug == true) else {
return
}

Expand Down Expand Up @@ -150,6 +147,7 @@ extension SentrySDK {
#endif
}()

fileprivate var enableDebug : Bool = false
fileprivate var sentryDSN : String = ""
fileprivate var enableSMFLogUpload : Bool = true
fileprivate var enableBreadcrumbs : Bool = true
Expand All @@ -162,7 +160,7 @@ extension SentrySDK {
/// - enableSMFLogUpload: true if you want the SMFLogger logs to be submitted with a crash
/// - enableBreadcrumbs: true if you want Sentry to attach the last user interaction before a crash
/// - smfLogUploadMaxSize: The max count of characters which should be uploaded
init(sentryDSN: String? = nil, enableSMFLogUpload: Bool = true, smfLogUploadMaxSize: Int = SentryConstants.smfLogUploadMaxSizeDefault, smfEnableBreadcrumbs: Bool = true) {
init(sentryDSN: String? = nil, enableSMFLogUpload: Bool = true, smfLogUploadMaxSize: Int = SentryConstants.smfLogUploadMaxSizeDefault, smfEnableBreadcrumbs: Bool = true, enableDebug: Bool = false) {

// Get the Sentry DSN
let dsnFromPlist = Bundle.main.object(forInfoDictionaryKey: SentryConstants.plistSentryDsn) as? String
Expand All @@ -172,6 +170,7 @@ extension SentrySDK {
return
}

self.enableDebug = enableDebug
self.sentryDSN = _sentryDsn
self.enableBreadcrumbs = smfEnableBreadcrumbs
self.enableSMFLogUpload = enableSMFLogUpload
Expand Down