Added AppCenterSDK file for mac (removed distribution features)#98
Merged
Added AppCenterSDK file for mac (removed distribution features)#98
Conversation
Tomusm
reviewed
Nov 8, 2019
| @@ -0,0 +1,164 @@ | |||
| // | |||
Contributor
There was a problem hiding this comment.
Do we need that file ? What are the differences with AppCenterSDK+HiDrive ?
I would assume that we use the same implementation, better reduce the number of files to maintain.
Author
There was a problem hiding this comment.
The problem is, that the AppCenterDistribute module is not available for mac .. and as you don't need any distribution logic i just removed the import statement and any associated code
Contributor
There was a problem hiding this comment.
What about extracting the Distribution code in an extension in the same file, and surrounding it by #if !os(macOS) ?
(Not sure if it actually works, just a random idea)
Author
There was a problem hiding this comment.
doesn't sound that bad i can try that
Tomusm
approved these changes
Nov 8, 2019
kmeinh
approved these changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.