build: fail usr-so3 deploy clearly when the user space is not built#260
Merged
Conversation
do_deploy rsync'd from so3/usr/build/deploy/ without checking it exists.
On a fresh clone (or when only the kernel was built), that directory is
missing and deploy aborted with a cryptic "rsync ... (code 23)". Check
the source dir up front and bb.fatal with an actionable hint
("build.sh -x usr-so3" / "build.sh bsp-so3"). The check runs before the
rootfs loop-mount, so a missing build no longer leaves a dangling mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a fresh clone (or when only the kernel was built),
deploy.sh bsp-so3fails with an opaque error:usr-so3:do_deployrsync'd fromso3/usr/build/deploy/without checking it exists, and it had already loop-mounted the rootfs — so the abort also left a dangling mount behind.Fix
Check the deploy source dir before mounting the rootfs, and
bb.fatalwith an actionable message if it's missing:Because the check runs before
__do_rootfs_mount, a missing build no longer leaves a dangling loop mount. No behaviour change when the user space is built.