Migrate the favorites module to typescript, add wiremock tests and remove the 'test_' prefix from test names #140
+1,306
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move the test_ prefix from test names
The latest changes improve test assertions by using comprehensive object matching. No new issues found in this update.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
ggoranov-smar
requested changes
Dec 1, 2025
test/mock-api/favorites/remove_multiple_favorites_convenience_functions.spec.ts
Outdated
Show resolved
Hide resolved
test/mock-api/favorites/remove_multiple_favorites_convenience_functions.spec.ts
Outdated
Show resolved
Hide resolved
…ype enum, add an array check for the objectIds, add AddFavoriteConvenienceOptions type
ggoranov-smar
requested changes
Dec 2, 2025
ggoranov-smar
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.