chore: allow configuring fastcgi_pass through environment variable#4
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make the fastcgi_pass upstream configurable via an environment variable so the nginx container can be deployed more flexibly (e.g., in Kubernetes).
Changes:
- Replace the hard-coded
fastcgi_pass phpfpm:9000;with an environment-variable-based value in the nginx config template.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| location ^~ { | ||
| alias /var/www/html/public; | ||
|
|
||
| location ~ \.php(/|$) { | ||
| fastcgi_pass phpfpm:9000; | ||
| fastcgi_pass ${FASTCGI_PASS}; |
There was a problem hiding this comment.
location directive is syntactically invalid as written: location ^~ { is missing the required URI/prefix (e.g., /). Nginx will fail to start with a config parse error; please add the intended location match after ^~ (or change to a valid location / { ... } block).
This should allow running the container properly in Kubernetes.