Skip to content

Conversation

@jumaallan
Copy link
Member

@jumaallan jumaallan commented Jul 16, 2025

User description

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.


PR Type

Enhancement


Description

• Remove AntiFraud response from JobStatus calls
• Delete SuspectUser and Antifraud classes from types
• Update BiometricKyc and EnhancedDocumentVerification result constructors
• Add changelog entry documenting the removal


Changes walkthrough 📝

Relevant files
Enhancement
types.ts
Remove AntiFraud types and properties                                       

src/types.ts

• Removed SuspectUser and Antifraud class definitions
• Removed
antifraud property from BiometricKycJobResult class
• Removed
antifraud property from EnhancedDocumentVerificationJobResult class

Updated constructors to remove antifraud parameter

+0/-24   
Documentation
CHANGELOG.md
Document AntiFraud removal in changelog                                   

CHANGELOG.md

• Added unreleased section documenting AntiFraud response removal

+6/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Jul 16, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    Removal of antifraud parameter from constructors may break existing code that passes this parameter. Consider checking for any existing usages or providing migration guidance.

    constructor(
      actions: Actions,
      resultCode: string,
      resultText: string,
      resultType: string,
      smileJobId: string,
      partnerParams: PartnerParams,
      dob?: string,
      photoBase64?: string,
      gender?: string,
      idType?: string,
    Missing Assignment

    Constructor parameters like fullName, idNumber, phoneNumber, etc. are accepted but not assigned to instance properties in both BiometricKycJobResult and EnhancedDocumentVerificationJobResult classes.

      previousRegistrantsUserIds?: string[]
    ) {
      this.actions = actions;
      this.resultCode = resultCode;
      this.resultText = resultText;
      this.resultType = resultType;
      this.smileJobId = smileJobId;
      this.partnerParams = partnerParams;
      this.dob = dob;
      this.photoBase64 = photoBase64;
      this.gender = gender;
      this.idType = idType;

    @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Jul 16, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @wangerekaharun wangerekaharun left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Tested this on Android + iOS and works well

    @jumaallan jumaallan merged commit e2bcca1 into main Jul 16, 2025
    11 checks passed
    @jumaallan jumaallan deleted the feat/remove-antifraud branch July 16, 2025 18:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants