-
Notifications
You must be signed in to change notification settings - Fork 4
Feat: Update Android & iOS SDKs to v11.1.0 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a45ed6e
Update SDK to version 11.1.0 and enhance auto capture functionality
wangerekaharun 0d78160
Add auto capture feature and update consent handling in biometric KYC…
wangerekaharun 318d9de
Add auto capture timeout and update consent handling in SmileID integ…
wangerekaharun b9b88fb
Update changelog for release 11.1.0 and bump package version
wangerekaharun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -25,18 +25,24 @@ import com.smileidentity.compose.document.DocumentCaptureSide | |||||||||||||
| import com.smileidentity.compose.theme.colorScheme | ||||||||||||||
| import com.smileidentity.compose.theme.typography | ||||||||||||||
| import com.smileidentity.metadata.LocalMetadataProvider | ||||||||||||||
| import com.smileidentity.models.AutoCapture | ||||||||||||||
| import com.smileidentity.react.results.DocumentCaptureResult | ||||||||||||||
| import com.smileidentity.react.utils.DocumentCaptureResultAdapter | ||||||||||||||
| import com.smileidentity.util.randomJobId | ||||||||||||||
| import timber.log.Timber | ||||||||||||||
| import java.io.File | ||||||||||||||
| import kotlin.time.Duration.Companion.seconds | ||||||||||||||
|
|
||||||||||||||
| class SmileIDDocumentCaptureView(context: ReactApplicationContext) : SmileIDView(context) { | ||||||||||||||
| var showConfirmation: Boolean = true | ||||||||||||||
| var front: Boolean = true | ||||||||||||||
| var allowGalleryUpload: Boolean = false | ||||||||||||||
| var idAspectRatio: Float? = null | ||||||||||||||
|
|
||||||||||||||
| var autoCaptureTimeout: Int? = null | ||||||||||||||
|
|
||||||||||||||
| var autoCapture: AutoCapture? = null | ||||||||||||||
|
|
||||||||||||||
| override fun renderContent() { | ||||||||||||||
| composeView.apply { | ||||||||||||||
| val customViewModelStoreOwner = CustomViewModelStoreOwner() | ||||||||||||||
|
|
@@ -71,6 +77,8 @@ class SmileIDDocumentCaptureView(context: ReactApplicationContext) : SmileIDView | |||||||||||||
| showAttribution = showAttribution, | ||||||||||||||
| allowGallerySelection = allowGalleryUpload, | ||||||||||||||
| showConfirmation = showConfirmation, | ||||||||||||||
| autoCaptureTimeout = autoCaptureTimeout?.seconds ?: 10.seconds, | ||||||||||||||
| autoCapture = autoCapture ?: AutoCapture.AutoCapture, | ||||||||||||||
|
Comment on lines
+80
to
+81
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: The timeout conversion could fail if
Suggested change
|
||||||||||||||
| showSkipButton = false, | ||||||||||||||
| instructionsHeroImage = hero, | ||||||||||||||
| instructionsTitleText = stringResource(instructionTitle), | ||||||||||||||
|
|
||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The function should handle null input gracefully since it's called with nullable strings. Consider returning a default value or making the parameter nullable to prevent runtime crashes. [possible issue, importance: 7]