[pull] main from emscripten-core:main#105
Merged
pull[bot] merged 3 commits intosmilers:mainfrom May 27, 2021
Merged
Conversation
Using addAtMain stopped working for programs without main functions (HAS_MAIN not defined) after #13901. Code that needs to populate the FS is mostly likely going to be run during preRun callback which all happen before ATINITs.
Also, add more testing in order to verify that finding resources inside the sysroot works as expected. See: emscripten-core/emsdk#824 See: #6595 I'm not sure if this is also fixes #6595 and will likely followup with a test for find_package. Fixes: #10078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )