Skip to content

Update all usages of faker's randomDigit to randomNumber#1

Merged
smithandre merged 1 commit intomasterfrom
feature/standardize-faker-usage
Oct 13, 2017
Merged

Update all usages of faker's randomDigit to randomNumber#1
smithandre merged 1 commit intomasterfrom
feature/standardize-faker-usage

Conversation

@smithandre
Copy link
Owner

@smithandre smithandre commented Oct 13, 2017

Updating all usages of faker's randomDigit to randomNumber

Description

Changed all usages of Faker's randomDigit to randomNumber

Motivation and Context

A stab at solving dbudwin#94

How Has This Been Tested?

I executed PHPuni tests locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ X ] Enhancement (non-breaking change which is not noticeable to end users)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x ] My code follows the code style of this project.
  • My change requires an update to the README and I have updated it accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x ] This is a complete change and doesn't leave the project in a bad state.
  • [ x ] All new and existing tests passed.

@smithandre smithandre merged commit ed2b692 into master Oct 13, 2017
@smithandre smithandre deleted the feature/standardize-faker-usage branch October 13, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant