Properly handle event payload members of blob and string type#1064
Merged
sugmanue merged 3 commits intosmithy-lang:mainfrom Mar 12, 2026
Merged
Properly handle event payload members of blob and string type#1064sugmanue merged 3 commits intosmithy-lang:mainfrom
sugmanue merged 3 commits intosmithy-lang:mainfrom
Conversation
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Outdated
Show resolved
Hide resolved
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Outdated
Show resolved
Hide resolved
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Outdated
Show resolved
Hide resolved
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Show resolved
Hide resolved
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Outdated
Show resolved
Hide resolved
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Outdated
Show resolved
Hide resolved
...event-streams/src/main/java/software/amazon/smithy/java/aws/events/AwsEventShapeEncoder.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Mar 12, 2026
mtdowling
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Properly handle event payload members of blob and string type, those are serialized directly into the event payload using a different content-type header.
Serializes a member with the trait
@eventPayloaddirectly into the payload of the event. The following member types have special handling::content-typeheader is set to "application/octet-stream":content-typeheader is set to "text/plain":content-typeis added as header of the messageBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.