Improve Java HTTP client integration#1206
Merged
Merged
Conversation
mtdowling
force-pushed
the
improve-http-client
branch
from
b5340da to
2a04fa7
Compare
Use buffers as-is without copying, add support for direct buffers to Jackson codec, improve HTTP header wrapper to use underlying data more, improve how we send data to Java client by adding a small adapter to avoid double-wrapping the publisher
adwsingh
force-pushed
the
improve-http-client
branch
from
2a04fa7 to
55291a1
Compare
adwsingh
reviewed
May 23, 2026
| */ | ||
| private static void setDefaultTuningProperties() { | ||
| setIfUnset("jdk.httpclient.maxframesize", "65536"); | ||
| setIfUnset("jdk.httpclient.maxstreams", "1024"); |
Contributor
There was a problem hiding this comment.
Why did we remove this and switch to the default of 100?
adwsingh
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use buffers as-is without copying, add support for direct buffers to Jackson codec, improve HTTP header wrapper to use underlying data more, improve how we send data to Java client by adding a small adapter to avoid double-wrapping the publisher
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.