chore: upgrade smithy to 1.6.1; kotlin 1.4.31; gradle 6.8.3; coroutines 1.4.3 #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kggilmer
approved these changes
Mar 8, 2021
Contributor
kggilmer
left a comment
kggilmer
left a comment
There was a problem hiding this comment.
Maybe a typo on one of the versions as noted, otherwise loving the cleanup!
| @@ -1,5 +1,5 @@ | |||
| plugins { | |||
| kotlin("jvm") version "1.4.10" | |||
| kotlin("jvm") version "1.4.30" | |||
Contributor
There was a problem hiding this comment.
Should this be 1.4.31 as below in gradle.properties?
Contributor
Author
There was a problem hiding this comment.
Yes good catch, although this project should just be deleted, it's not even POC worthy, it's raw ideas from way far back. Not going to worry about it and we can just delete this entire design directory (it's not even linked in settings.gradle.kts)
| * Get all shapes of a particular type from the model. | ||
| * Equivalent to `model.shapes({ShapeType}::class.java)`. | ||
| * | ||
| * NOTE: this is usually not what you want as it will return all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #134
Description of changes:
appliesTohttpRequestTestpropertyresolvedHostwhich allows testing endpoint behaviorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.