diagnostics: add hint to message, if present #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
requested changes
Aug 22, 2025
src/main/java/software/amazon/smithy/lsp/diagnostics/SmithyDiagnostics.java
Show resolved
Hide resolved
|
I didn't even know we had a |
…gnostics.java Co-authored-by: Miles Ziemer <45497130+milesziemer@users.noreply.github.com>
milesziemer
approved these changes
Aug 25, 2025
|
My suggestion failed checkstyle. I'll fix it. |
milesziemer
added a commit
to milesziemer/smithy-language-server
that referenced
this pull request
Aug 25, 2025
My suggestion in smithy-lang#230 didn't pass checkstyle.
Merged
milesziemer
added a commit
that referenced
this pull request
Aug 26, 2025
My suggestion in #230 didn't pass checkstyle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add a diagnostic's hint to the message, if there is one present.
Tested manually. I didn't find any real validations in the Smithy repo that would include a hint, so I don't see an easy way to test this with real diagnostics. Built-in validators like
EmitEachSelectorValidatoralso don't support adding hints.Is it OK to go without a test?
toDiagnosticis in a private interface too, so I can't unit test it without refactoring.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.